-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow adding public assets through the CLI #727
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I want a small logging entry.
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Maybe this could be a follow-up issue - I found that FM complains about an asset being added to an account if there is already a public asset with the same name (I added two debug logs for clarity, "New asset data:" and "Found asset:"):
I feel that the query in
|
… special case for public assets (#728)# Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…is more robust against duplicate asset names already being present in the database. Signed-off-by: F.N. Claessen <felix@seita.nl>
…`first` is more robust against duplicate asset names already being present in the database." This reverts commit 64b9632.
… special case for public assets (#728)# Signed-off-by: Nicolas Höning <nicolas@seita.nl>
…g present in the database. Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
No description provided.