-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli unit conversion for adding data #341
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
@nhoening I'm not sure whether you intend to have CLI changelog entries for these kind of changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new function covered by tests, probably sensor schema or API tests?
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…it conversion Signed-off-by: F.N. Claessen <felix@seita.nl>
Yes, by |
Add a test for switching signs and fix the regression (from #341) that broke that conversion. Also add a test for another unit that includes a scaling factor (l/100km, used for car fuel consumption), and comment out two test cases that show the current limitations of our unit conversion function. * Use FlexMeasures unit registry Signed-off-by: F.N. Claessen <felix@seita.nl> * Fix and test conversion from -W to W Signed-off-by: F.N. Claessen <felix@seita.nl> * Refactor Signed-off-by: F.N. Claessen <felix@seita.nl>
This PR adds a CLI option to pass a data unit when reading in time series data from CSV, so data can automatically be converted to the sensor unit. Also allows to swap signs.