-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] anilist
: Exception if field is not set on the site
#2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alphabetize Entry() fields to make code more readable
liiight
reviewed
Jul 23, 2020
liiight
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that build failure seems unrelated, looking into it
ianstalk
reviewed
Jul 23, 2020
ianstalk
reviewed
Jul 23, 2020
Empty strings caused an exception when performing case operations, the reason I had the string conversions in place.
Sent from my Samsung Galaxy smartphone.
|
Then check if it has a value before manipulating it.
…On Thu, Jul 23, 2020, 7:40 PM BrutuZ ***@***.***> wrote:
Empty strings caused an exception when performing case operations, the
reason I had the string conversions in place.
Sent from my Samsung Galaxy smartphone.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2710 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLLRB4DXSA4LZAXKENHATR5DC5TANCNFSM4PE23KNA>
.
|
Testing for empty value now |
ianstalk
approved these changes
Jul 25, 2020
Bump. I'm stuck at this 3.1.68 branch since a couple of entries in my list have empty values that aren't handled without this, hence crashing the task. |
Paging @Flexget |
Seems good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for changes:
Discovered that site entries could have empty fields, usually ones added from very early announcements or teasers. That would result in exceptions due to parsing errors since some fields were taken for granted.
Detailed changes:
dict().get()
NoneType
exceptionsal_links
output:[{'site': '*site_name*', 'url': '*site_url*'}, ... ]
{'*site_name*': '*site_url*', ... }
Entry()
fields to improve code readability