Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #239: Don't ignore explicitly mentioned folders, even tho… #240

Closed
wants to merge 2 commits into from

Conversation

tladesignz
Copy link

…ugh they might contain otherwise ignored folders as their parent folders.

Fixes #239

Proposed Changes

  • Cuts off user-given base folders, only checks automatically scanned folders therein, if they contain an ignored item.

As discussed on the issue!

…even though they might contain otherwise ignored folders as their parent folders.
@FlineDevPublic
Copy link
Collaborator

FlineDevPublic commented Jan 14, 2022

@tladesignz Thank you very much for this PR. I just actually "merged" with some changes in 4d865ca & fd17d05 to fix some code conventions (skipped the creating a PR on your fork and just pushed right away). Closing this. 🎉


This comment was written during my regular Open Source live stream on Twitch. Follow me there to support my work!

@tladesignz
Copy link
Author

Yay! Thank you!

@FlineDevPublic
Copy link
Collaborator

@tladesignz This was just released in 4.9.0. 🎉


This comment was written during my regular Open Source live stream on Twitch. Follow me there to support my work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit folders on the codePaths argument shouldn't be ignored later.
2 participants