Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix newValue in the pre phase of the ConfigValueUpdateEvent #146

Merged
merged 1 commit into from
Feb 27, 2021
Merged

Fix newValue in the pre phase of the ConfigValueUpdateEvent #146

merged 1 commit into from
Feb 27, 2021

Conversation

derrop
Copy link
Member

@derrop derrop commented Feb 27, 2021

Fixes that the newValue in the ConfigValueUpdateEvent is actually the old value in the PRE phase and not the new one

@derrop derrop added bug Something isn't working needs review labels Feb 27, 2021
@derrop derrop self-assigned this Feb 27, 2021
@juliarn juliarn merged commit 0b0b29b into develop Feb 27, 2021
@juliarn juliarn deleted the fix/pre-config-value-update-event branch February 27, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliarn juliarn juliarn approved these changes

Assignees

@derrop derrop

Labels
bug Something isn't working needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derrop @juliarn