OD-573 [Feature] Added translation to Widget-MenuDefault #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksandrLavrynenko
changed the title
OleksandrLavrynenko
changed the title
OleksandrLavrynenko
changed the title
tonytlwu
requested changes
Oct 13, 2021
.eslintrc
Outdated
| { | ||
| "extends": "fliplet", | ||
| "globals": { | ||
| "Modernizr": "readonly" |
There was a problem hiding this comment.
If you update the eslint config to the latest version you won't need to set any global variable. Please check all other menu components too.
There was a problem hiding this comment.
I fixed it in all components
tonytlwu
requested changes
Oct 20, 2021
Co-authored-by: Tony Wu <tonytlwu@users.noreply.github.com>
tonytlwu
reviewed
Oct 27, 2021
There was a problem hiding this comment.
@romanyosyfiv @inna-bieshulia Translation looks ready. This can be tested once API is ready.
tonytlwu
changed the title
tonytlwu
approved these changes
May 9, 2022
squallstar
reviewed
May 25, 2022
| @@ -2,7 +2,11 @@ | |||
| <div class="fl-viewport-header {{#if location}}fl-viewport-header-left{{/if}}"> | |||
| {{#if location}} {{#if canGoBack}} | |||
| <span class="nav-left fl-menu-back focus-outline" data-fl-navigate-back tabindex="0"> | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
@OleksandrLavrynenko you merged a git conflict here.
squallstar
reviewed
May 25, 2022
| @@ -20,7 +24,11 @@ | |||
| </span> | |||
| {{else}} {{#if canGoBack}} | |||
| <span class="nav-left fl-menu-back focus-outline" data-fl-navigate-back tabindex="0"> | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
@OleksandrLavrynenko you merged a git conflict here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sofiiakvasnevska
OD-573 https://weboo.atlassian.net/browse/OD-573
Description
Added user translations in component MenuDefault
Backward compatibility
This change is fully backward compatible.
Reviewers
@upplabs-alex-levchenko