Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Envie.values() #5

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Implement Envie.values() #5

merged 1 commit into from
Jul 11, 2018

Conversation

KATT
Copy link
Contributor

@KATT KATT commented Jun 13, 2018

Use case:

const envie = require('envie')
const Joi = require('joi')

const { PORT } = envie({
  PORT: Joi
    .number()
    .min(0)
    .default(0)
    .description('Port on which the HTTP server will listen'),
}).values()

server.listen(PORT)

@coveralls
Copy link

coveralls commented Jun 13, 2018

Coverage Status

Coverage increased (+0.01%) to 99.296% when pulling aa6bfac on KATT:feature/values() into b638df2 on Floby:master.

@Floby
Copy link
Owner

Floby commented Jul 11, 2018

Oh hey, sorry I'm not very quick on noticing pull requests !
I like this one, thank you. I think it qualifies nicely as the next minor release. I'll let you know here when it's released. Gotta accept the #9 first an publish it as a patch.

@Floby Floby merged commit 766a127 into Floby:master Jul 11, 2018
@KATT KATT deleted the feature/values() branch July 11, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants