-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh the intermediate and CA certs #249
Conversation
@plutonium-239 they're using a "Let's Encrypt" certificate, so each 90 days the certificate need to be renewed and therefore updated in this An automated pipeline could solve this by submitting a PR to update the cert like 10/15 days before the expiration date. All you have to do is to download the certificate from floobits.com and update the |
@zedtux yeah, but someone would need to accept those PRs too :( |
For sure! |
@zedtux has the updated version been working for you? It still gives me an SSL error, |
@zedtux well i tried a lof things involving adding CA certs downloaded from the website (which were same as the ones in cert.py and floobits.pem) to my cacert.pem in hopes that maybe it is using just |
Regarding your previous comment, this PR was working fine until the expiration date of the cert. Now regarding your last comment, that's strange you didn't succeeded to make it working as updating the certs should work as it did work for me in the past.
Well, this repos is just the Sublime Text plugin, not floobits itself, so until you have a big picture of floobits and have information I don't have, I don't see why the floobits project would be in danger due to this issue. Anyways, what would help a lot would be to have a really SSL cert, so that it doesn't change (But it will depend on the revenue of the app), or to automate it. I'm sorry but:
|
It was impossible for me to login and use Floobits in Sublime since I was facing an SSL certificate validation.
With this change, the plugin works well.