Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix Issue #63 to properly set the x-forwarded-host header #64

Merged
merged 4 commits into from
Jan 30, 2024
Merged

fix: Fix Issue #63 to properly set the x-forwarded-host header #64

merged 4 commits into from
Jan 30, 2024

Conversation

peter-at-work
Copy link
Contributor

@peter-at-work peter-at-work commented Jan 30, 2024 •
edited
Loading

Fix for #63

When the xfwd configuration option is enabled, the x-forwarded-host header was getting set with an empty value. This fixes the issue by reading the host header from the original request.

FlorianRappl
FlorianRappl approved these changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed - thanks for noticing!

LGTM!

@FlorianRappl FlorianRappl merged commit 5c271cb into FlorianRappl:develop Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianRappl FlorianRappl FlorianRappl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-at-work @FlorianRappl