Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add automated test for create key manually -> download #1074

Closed
1 of 3 tasks
tomholub opened this issue May 1, 2018 · 5 comments · Fixed by #2182
Closed
1 of 3 tasks

add automated test for create key manually -> download #1074

tomholub opened this issue May 1, 2018 · 5 comments · Fixed by #2182
Assignees
@tomholub
Labels
actionable test would prevent past issue
Milestone
7.4.0: Dynamic or...

Comments

@tomholub
Copy link
Collaborator

tomholub commented May 1, 2018 •
edited by michael-volynets

  • fix it (got fixed on recent versions)
  • add test (on chrome)
  • also test settings -> backup -> as file
@tomholub tomholub added this to the 5.4.6: Bugfixes milestone May 1, 2018
This was referenced May 2, 2018
Closed
Closed
@tomholub tomholub modified the milestones: 5.4.6: Bugfixes, Ideas L2 May 6, 2018
@tomholub tomholub changed the title create key manually -> download broken add automated test for create key manually -> download Apr 4, 2019
@tomholub
Copy link
Collaborator Author

not really fixed: #2115

@michael-volynets
Copy link
Contributor

To clarify,
I need to write a test that's going to download the key and compare it with the original key, am I right?

@tomholub
Copy link
Collaborator Author

You don't actually need to compare the key, just test that you are able to proceed through setup by creating your own key, and then choosing the "download as file" backup method.

@michael-volynets
Copy link
Contributor

Okay, got it
thanks

michael-volynets added a commit that referenced this issue Nov 15, 2019
@michael-volynets
Issue #1074, created test and extended .createAdvanced method
c942c37
@michael-volynets michael-volynets mentioned this issue Nov 15, 2019
Merged
@tomholub
Copy link
Collaborator Author

Re-assigning to myself, to evaluate the PR when I get a chance

tomholub pushed a commit that referenced this issue Dec 11, 2019
@michael-volynets
Issue #1074 test file backup during setup (#2182)
97aaa32 
* Issue #1074, created test and extended .createAdvanced method

* Removed .only

* original code

* test file backup during setup

* add a delay for pass phrase test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomholub tomholub

Labels
actionable test would prevent past issue
Projects
None yet
Milestone
7.4.0: Dynamic org rules
Development

Successfully merging a pull request may close this issue.

Issue #1074 test file backup during setup FlowCrypt/flowcrypt-browser
2 participants
@tomholub @michael-volynets