issue #3992 [Setup] Fix showing error modal when uploading invalid private key #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrooommmaaa
suggested changes
Oct 15, 2021
| @@ -14,6 +14,7 @@ import { KeyUtil } from '../../core/crypto/key'; | |||
| export type SavePassphraseChecks = { | |||
| isSavePassphraseHidden?: boolean | undefined, | |||
| isSavePassphraseChecked?: boolean | undefined | |||
| isInvalidKey?: boolean | undefined | |||
There was a problem hiding this comment.
This check isn't related to "save passphrase", so the type name SavePassphraseChecks would no longer be relevant.
Moreover, these checks are supposed to be optional (can be skipped), which is not the case with invalid key -- we HAVE to dismiss the alert to proceed with the recipe, so conceptually this is not the best place for this parameter.
Can we put it somewhere to ManualEnterOpts maybe?
rrrooommmaaa
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes showing the error modal when user imports invalid key file. The functionality was already there, but it was broken.
close #3992
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):