-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up and improve tests #5088
Conversation
@sosnovsky Why sometimes there is only one artefact when 2 tests are failed? It generally looks as if gmail live tests run in parallel (with another instance of test suite?) |
Looks like we're storing only 1 file in Artifacts folder even when multiple are written: Should be fixed too, here is code in |
It shouldn't be possible, I think, as live tests run only in |
Do you know why we have pool of 3 browsers for gmail live tests? Does this make sense? |
Not sure, maybe previously we ran live tests simultaneously, but for now we don't need these 3 browsers, just 1 will be enough. |
Changing this value to 1 dramatically increased the run time to over an hour |
I think most of the updates are already incorporated into PR #5069. |
@rrrooommmaaa probably now you can work on this one, as live tests are still failing |
We can also use flowcrypt-browser/test/source/tests/page-recipe/gmail-page-recipe.ts Lines 14 to 16 in cbb2aff
|
@@ -433,7 +457,8 @@ export const defineGmailTests = (testVariant: TestVariant, testWithBrowser: Test | |||
}) | |||
); | |||
|
|||
test( | |||
// convo-sensitive, draft-sensitive test | |||
test.serial( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll be run serially anyway. I can leave this serial
as precaution or delete it
Is this |
This reverts commit f521bdd.
Actually, as richtext option is disabled in Chrome, the |
Then let's leave it for now, until we'll find another way to enable richtext option on Chrome for tests (or it'll be ready to be enabled by default on Chrome too) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR speeds up live gmail tests by testing iframes directly,
also makes more strict checks that no leftover original attachment remain
close #4929 (pattern
getFramesUrls
and thenbrowser.newPage
was removed except where necessary) -- main bulk was updated in #5069Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):