Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5498 Upgrade to puppeteer v22 #5592

Merged
merged 109 commits into from
Jun 26, 2024
Merged

#5498 Upgrade to puppeteer v22 #5592

merged 109 commits into from
Jun 26, 2024

Conversation

sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented Feb 5, 2024

This PR updates test code to be compatible with puppeteer v22

close #5498
close #5396


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky marked this pull request as ready for review June 25, 2024 18:47
@sosnovsky sosnovsky requested a review from ioanmo226 June 25, 2024 19:27
@sosnovsky
Copy link
Collaborator Author

@ioanmo226 this one is finally ready for review

Copy link
Collaborator

@ioanmo226 ioanmo226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ioanmo226 ioanmo226 merged commit ee9d4e0 into master Jun 26, 2024
14 checks passed
@ioanmo226 ioanmo226 deleted the 5498-puppeteer-v21 branch June 26, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade puppeteer to v22 Debug html attachments on Semaphore not contain screenshots
2 participants