Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack 'Update' button on Instance Settings/General page takes you to wrong place #1898

Closed
knolleary opened this issue Mar 30, 2023 · 0 comments · Fixed by #1970
Closed

Stack 'Update' button on Instance Settings/General page takes you to wrong place #1898

knolleary opened this issue Mar 30, 2023 · 0 comments · Fixed by #1970
Assignees
@knolleary
Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working priority:high High Priority
Milestone
1.6

Comments

@knolleary
Copy link
Member

Current Behavior

If there is an updated stack available for an instance we display an 'update' button next to the stack info. This button originally took you to the 'danger' page where the actual 'update stack' button was shown.

In 1.5, we moved the 'danger' options to the bottom of the 'general' page and removed the menu entry for the Danger page. However the 'update' button still takes you to the Danger page - not sure why we left the entry for it in routes.js..

The actual 'Update Stack' button the user needs to click on is just a few pixels below... see screenshot.

image

Is the small 'update' button useful if the 'Update Stack' button is shown so nearby? Maybe, rather than a button, it could just be a visual notification pill/icon thing with a tooltip directing the user to click the button below.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

  • FlowForge version:
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser:
@knolleary knolleary added needs-triage Needs looking at to decide what to do area:frontend For any issues that require work in the frontend/UI bug Something isn't working and removed needs-triage Needs looking at to decide what to do labels Mar 30, 2023
@knolleary knolleary added this to the 1.6 milestone Mar 30, 2023
@knolleary knolleary added the priority:high High Priority label Apr 12, 2023
@knolleary knolleary self-assigned this Apr 12, 2023
knolleary added a commit that referenced this issue Apr 12, 2023
@knolleary
Navigate to instance settings from stack update button
e856220 
Fixes #1898
@knolleary knolleary mentioned this issue Apr 12, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knolleary knolleary

Labels
area:frontend For any issues that require work in the frontend/UI bug Something isn't working priority:high High Priority
Projects
🛠 Development
Archived in project
Milestone
1.6
Development

Successfully merging a pull request may close this issue.

Navigate to instance settings from stack update button FlowFuse/flowfuse
1 participant
@knolleary