Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to instance settings from stack update button #1970

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Apr 12, 2023

Fixes #1898

Description

The 'update' button on the instance overview page now takes you to /settings/overview - not the danger page that was removed a couple releases ago.

On the /settings/overview page I've removed the update button as that was also going to the danger page, whereas now the real button is on the same screen. (See the linked issue for what I mean...)

I tried a few variations of replacing the button with some notification that an update was available but nothing quite worked. Rather than spin my wheels on that, I've removed it entirely.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@joepavitt joepavitt merged commit 6b774c6 into main Apr 12, 2023
@joepavitt joepavitt deleted the stack-update-button-fix branch April 12, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack 'Update' button on Instance Settings/General page takes you to wrong place
2 participants