Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to point to new /editor/<tab> view for Instances #3658

Closed
Tracked by #3646
joepavitt opened this issue Mar 28, 2024 · 4 comments · Fixed by #3761
Closed
Tracked by #3646

Update links to point to new /editor/<tab> view for Instances #3658

joepavitt opened this issue Mar 28, 2024 · 4 comments · Fixed by #3761
Assignees
Labels
area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.

Comments

@joepavitt
Copy link
Contributor

joepavitt commented Mar 28, 2024

Depends on: #3656

In the original issue, the /editor view was added, but not made the default view. Here, whenever a user clicks an instance in the "Applciations" or "Instances" view, that button should navigate to the new "Editor" view.

@joepavitt joepavitt added size:XS - 1 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story. area:frontend For any issues that require work in the frontend/UI labels Mar 28, 2024
@cstns
Copy link
Contributor

cstns commented Apr 19, 2024

covered by Add new /instance/editor view #3656

@cstns cstns closed this as completed Apr 19, 2024
@joepavitt
Copy link
Contributor Author

joepavitt commented Apr 19, 2024

This isn't covered by #3656 - this would also include removal of "Open Editor" from the main "Instances" and "Applications" view, and when clicking on the Instance row, navigating to the immersive view immediately.

Currently, we still have too many clicks to the editor:

Open FlowFuse > Click Instance > Open Editor

The middle click here should go straight to editor

@joepavitt joepavitt reopened this Apr 19, 2024
@cstns
Copy link
Contributor

cstns commented Apr 19, 2024

We can cover the removal of the button in #3657.

I agree on the too many clicks issue but we don't have access to the nr-launcher version on the main "Instances" and "Applications" and we need it in order to know what editor to open (immersive/default).

I think this will hinder us for quite some time, especially when fully transitioning to the immersive editor.

@cstns
Copy link
Contributor

cstns commented Apr 22, 2024

I had a discussion with @hardillb about this feature, and we could leave the open editor button in place in the main Instances and Applications view but would need some additional work to get the nr-launcher version on that page.

It would involve some more time to be put in to this task but I think it's worth the effort because the alternative workflow is sub optimal involving too many clicks for navigation.

I would also like to add, on the same page, an per instance "Actions" button (the same as on the instance overview page) to allow users to "mass assign" instance states from a single place.

Additional thoughts are more than welcomed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI size:XS - 1 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
Archived in project
Status: Done
2 participants