Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the editor link on the application instances list to point to the appropriate editor #3761

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

cstns
Copy link
Contributor

@cstns cstns commented Apr 23, 2024

Description

Updated the editor link on the application instances list to point to the appropriate editor

Related Issue(s)

closes #3658

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@cstns cstns self-assigned this Apr 23, 2024
@cstns cstns requested a review from joepavitt April 23, 2024 09:02
@cstns cstns added the area:frontend For any issues that require work in the frontend/UI label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.14%. Comparing base (f0d543d) to head (e53b1b0).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3761       +/-   ##
===========================================
+ Coverage   41.92%   79.14%   +37.21%     
===========================================
  Files         638      278      -360     
  Lines       24670    12487    -12183     
  Branches     6048     2761     -3287     
===========================================
- Hits        10344     9883      -461     
+ Misses      14326     2604    -11722     
Flag Coverage Δ
backend 79.14% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joepavitt joepavitt merged commit a5d38bb into main Apr 23, 2024
13 of 14 checks passed
@joepavitt joepavitt deleted the update-links-to-point-to-new-editor-tab branch April 23, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:frontend For any issues that require work in the frontend/UI deploy:pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update links to point to new /editor/<tab> view for Instances
2 participants