Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device provisioning API #1659

Merged
merged 40 commits into from
Feb 10, 2023
Merged

Device provisioning API #1659

merged 40 commits into from
Feb 10, 2023

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Feb 5, 2023

PR Strategy

gitGraph
    commit
    commit
    branch device-provisioning-api
    checkout device-provisioning-api
    commit
    commit
    branch device-provisioning-ui
    checkout device-provisioning-ui
    commit
    commit
    checkout device-provisioning-api
    merge device-provisioning-ui
    checkout main
    merge device-provisioning-api
    commit
Loading

Please review/approve but do not merge before #1664

Description

Adds endpoints (and supporting functions/logging/changes) for basic management of device auto provisioning AccessTokens.

Related Issue(s)

Part of #1212

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • [-] Issue/PR raised on flowforge/helm to update ConfigMap Template
    • [-] Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl added the area:migration Involves a database migration label Feb 5, 2023
fixes operator does not exist: character varying = integer
forge/lib/templates.js Outdated Show resolved Hide resolved
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed on the migration

@Steve-Mcl
Copy link
Contributor Author

@knolleary as discussed earlier, I have redone all manual operation testing using a local Postgres to ensure both starting from scratch and starting with existing DB (so that migration runs).

I have done this back and forth several times (after realising my dummy data was "expired") - but it was a good exercise in testing reliability.

Results...

From empty / new PG instance

image

From existing PG instance

Table before upgrade

image

Migration

image

DDL afterwards

image

image

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have #1664 merged into this branch, and the tests running clean on this PR, I'm 👍 on merging.

@Steve-Mcl Steve-Mcl merged commit 0b1e103 into main Feb 10, 2023
@Steve-Mcl Steve-Mcl deleted the device-provisioning-api branch February 10, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:migration Involves a database migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Automatic device join to project or easy setup scritpt for mass deploys
3 participants