-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device Provisioning UI #1664
Device Provisioning UI #1664
Conversation
frontend/src/pages/team/Devices/dialogs/ProvisioningCredentialsDialog.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial wording changes proposed.
but also want to consider a broader renaming in the ui to standardise on 'register' rather than 'provision'.
Have made some improvements to UX:
|
Initial review comments addressed & tests fixed. If there are further suggestions around wording, please let me know. Ta. re-review requested. |
@Steve-Mcl added a comment 5 minutes ago |
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
I'm happy with this as things stand - @knolleary you'v still got requested changes on your review, so I'll hold out from merging |
Looks like my comments have been actioned. I'm 👍🏻 on this now. |
will wait for tests to run, then all good to go @Steve-Mcl |
PR Strategy
device-provisioning-ui
before merging related PR Device provisioning API #1659Description
Implement the UI portion of Provisioning Tokens management
Related Issue(s)
#1212
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label