Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Provisioning UI #1664

Merged
merged 19 commits into from
Feb 10, 2023
Merged

Conversation

Steve-Mcl
Copy link
Contributor

PR Strategy

gitGraph
    commit
    commit
    branch device-provisioning-api
    checkout device-provisioning-api
    commit
    commit
    branch device-provisioning-ui
    checkout device-provisioning-ui
    commit
    commit
    checkout device-provisioning-api
    merge device-provisioning-ui
    checkout main
    merge device-provisioning-api
    commit
Loading

Description

Implement the UI portion of Provisioning Tokens management

Related Issue(s)

#1212

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass (see Device provisioning API #1659 )
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial wording changes proposed.

but also want to consider a broader renaming in the ui to standardise on 'register' rather than 'provision'.

@joepavitt
Copy link
Contributor

Have made some improvements to UX:

  • Target Snapshot included in the Provisioning Tokens table
  • Team Settings to use side navigation tabs (consistent with Project & Device)
  • Add slot into the "Register Device" dialog to provide more context as to the action available.

@Steve-Mcl
Copy link
Contributor Author

@joepavitt @knolleary

Initial review comments addressed & tests fixed.

If there are further suggestions around wording, please let me know. Ta.

re-review requested.

@knolleary
Copy link
Member

@Steve-Mcl added a comment 5 minutes ago

Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
@joepavitt joepavitt self-requested a review February 10, 2023 09:23
@joepavitt
Copy link
Contributor

I'm happy with this as things stand - @knolleary you'v still got requested changes on your review, so I'll hold out from merging

@knolleary
Copy link
Member

Looks like my comments have been actioned. I'm 👍🏻 on this now.

@joepavitt
Copy link
Contributor

will wait for tests to run, then all good to go @Steve-Mcl

@Steve-Mcl Steve-Mcl merged commit 4daf979 into device-provisioning-api Feb 10, 2023
@Steve-Mcl Steve-Mcl deleted the device-provisioning-ui branch February 10, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Automatic device join to project or easy setup scritpt for mass deploys
3 participants