Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit log license overage #1744

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Audit log license overage #1744

merged 6 commits into from
Feb 28, 2023

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Feb 23, 2023 •
edited
Loading

Description

NOTE: This PR depends on functionality added in #1743. This PR is based of 1743 & therefore should be merged FIRST.

Audit logging & related UI updates for overages:

  • Adds logging handler
  • Logs overages at point of creation
  • Utilises the housekeeper to log any overages at both startup and weekly points
  • Provides friendly text and icon for activity log
  • Adds test for new logger

Update: Swap limit and count wording for better readability following 1:1 review with @joepavitt
image

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • [-] Issue/PR raised on flowforge/helm to update ConfigMap Template
    • [-] Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl mentioned this pull request Feb 23, 2023
Merged
6 tasks
@Steve-Mcl Steve-Mcl linked an issue Feb 23, 2023 that may be closed by this pull request
Allow License overages #1639
Closed
Base automatically changed from allow-license-overages-1639 to main February 27, 2023 14:29
@Steve-Mcl Steve-Mcl mentioned this pull request Feb 28, 2023
Closed
@knolleary knolleary merged commit 74bbb8b into main Feb 28, 2023
@knolleary knolleary deleted the audit-log-license-overage branch February 28, 2023 09:13
@knolleary knolleary mentioned this pull request Feb 28, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow License overages
2 participants
@Steve-Mcl @knolleary