-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update behaviour when license expires #1757
Conversation
This is the discussion in #1739 which is where any other proposals should be discussed. I don't want one set of things agreed in the issue and then a different set of things implemented in the PR.
The proposal was based on what we could do today. It made it clear there were problems with that approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation feels like it is caught between the two proposals of #1744 - whether to suspend projects at end of the post-expiry grace period.
The current proposal is not to suspend projects. In which case a post-expiry grace period doesn't serve much purpose and should be removed from this PR.
But until we sign-off #1739 it's hard to sign-off an implementation.
also, removes now redundant code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from one comment, all looks okay.
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Committed suggestion to remove leftover debugging code/comment. |
Description
Based on notes in #1739
TO DECIDE
app.config
option namedlicense_warn_period
is set for30
daysapp.config
option namedlicense_grace_period
is set for30
daysapp.config
option namedlicense_expiry_stops_all
is set to false. Essentially meaning projects will NOT be stopped on expiry by default / as it stands.Screenshots of UI changes
Click to reveal
License Warning (30 days or less to expiry)
License Grace (less than 30 days after expiry)
License and grace expired
Changes
Related Issue(s)
#1739
Checklist
flowforge.yml
?flowforge/helm
to update ConfigMap Templateflowforge/CloudProject
to update values for Staging/ProductionLabels
backport
labelarea:migration
label