Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Instances: Simplify Project Navigation #1769

Merged

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 3, 2023

Merge target is the feature branch for application instances as part of #1689: feat-1689-application-instances

Description

Screenshot 2023-03-03 at 17 58 43

Screenshot 2023-03-03 at 17 58 54

Related Issue(s)

#1719

@Pezmc Pezmc requested a review from knolleary March 3, 2023 17:23
@knolleary
Copy link
Member

I'm not seeing the same thing as the screenshots.

When viewing an instance, I have the 'old' sidebar still - no navigation back to the project:

image

I'm pretty sure this isn't a local caching/rebuilding thing... although I can't 100% rule that out yet.

@knolleary
Copy link
Member

I'm not seeing the same thing as the screenshots.

User error... ignore me.


I'm not convinced the navigation is quite right - still feeling 'lost' when viewing an instance.

A difficultly we have is that for users with a single instance in the app (ie every existing user) there is a 1-1 mapping of Application and Instance, and they could have the same name. That makes it tricky to know if you're seeing the application name or the instance name in the navigation. I know we aren't doing a full redesign of the navigation in this iteration, so we can move ahead as-is. But I would like to try to spare some cycles to iterate on this within this release.

@knolleary knolleary merged commit 6ddd2da into feat-1689-application-instances Mar 7, 2023
@knolleary knolleary deleted the feat-1719-project-navigation branch March 7, 2023 13:55
@Pezmc Pezmc mentioned this pull request Mar 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants