Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Instances: Node-RED Logs Page #1783

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Application Instances: Node-RED Logs Page #1783

merged 4 commits into from
Mar 9, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 8, 2023

Merge target is the feature branch for application instances as part of #1689: feat-1689-application-instances

Description

First pass of the Node-RED logs pages for Applications and Instances

  • Extracts shared behaviour into a shared component
  • Adds an instance filter to the application page

Application

Screenshot 2023-03-08 at 18 25 48

Instance

Screenshot 2023-03-08 at 18 26 00

Related Issue(s)

#1719

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • [-] Backport needed? -> add the backport label
  • [-] Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary March 8, 2023 17:37
knolleary
knolleary approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the stub driver log messages. Spectrum would be proud.

@knolleary knolleary merged commit 0e0801f into feat-1689-application-instances Mar 9, 2023
@knolleary knolleary deleted the feat-1719-node-red-logs branch March 9, 2023 10:55
@Pezmc Pezmc mentioned this pull request Mar 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pezmc @knolleary