Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Instances: Team Devices #1809

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Application Instances: Team Devices #1809

merged 6 commits into from
Mar 14, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Mar 13, 2023

Description

Updates team devices page to be consistent with Application > Instances and Instance > Remote Instances by making use of the DeviceBrowser component.

Additionally adds a description to the register new device modal for the Application > Instances and Instance > Remote Instances Popups

Before

Screenshot 2023-03-13 at 17 23 15

Screenshot 2023-03-13 at 17 24 33

After

Screenshot 2023-03-13 at 17 21 46

Screenshot 2023-03-13 at 17 24 42

Related Issue(s)

Closes #1801, part of #1689

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary
Copy link
Member

UX tests failing

 1) FlowForge platform admin users
       can view devices from teams they're not a member of:
     AssertionError: Timed out retrying after 4000ms: Expected to find element: `[data-el="devices"]`, but never found it.
      at Context.eval (webpack:///../test/e2e/frontend/cypress/tests/admin.spec.js:95:11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Add/Register Device buttons and dialogs
2 participants