Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent look and placement of "add" buttons, Add Device Dialog improved wording. #1812

Merged
merged 9 commits into from
Mar 14, 2023

Conversation

Steve-Mcl
Copy link
Contributor

Description

  • Improve consistency across the "Add/Register" buttons. Now all buttons are adjacent to search
    • Add device
    • Add token (provisioning)
    • Add Application
  • Ensure consistency across the "Add Device" dialogs
    • Improve readability (correct sentence order following addition of provisioning)

NOTE

Screenshots of consistent button placement and icon alignment

image
image
image
image
image

Screenshots of common device add dialog

image

Related Issue(s)

#1801

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl linked an issue Mar 13, 2023 that may be closed by this pull request
@Steve-Mcl Steve-Mcl changed the title Common look register buttons Consistent look and placement of "add" buttons, Add Device Dialog improved wording. Mar 13, 2023
@knolleary
Copy link
Member

We have no concept of a device being added to an Application but not to an instance. A device is either added to a Team (unassigned) or added to a Team and assigned to an Instance. So I think the dialog text should reflect that - it doesn't need all three states.

Currently, when opened from the Application view, it assigns the device straight to the one instance in the Application. Once we support multiple instances, the dialog will need to include a list of instances to pick from when opened from the Application view... but that's a next-week thing.

@Steve-Mcl
Copy link
Contributor Author

@knolleary @Pezmc

Sorry guys, I am not up to speed on the whole application/ instance concept & so I only rejigged what was present in the code for layout continuity. Could I pester you two this morning for 5m (huddle) to get a handle on the concept so I can finish this up please?

Base automatically changed from fix-1801-team-devices to main March 14, 2023 10:33
@knolleary knolleary merged commit 638b882 into main Mar 14, 2023
@knolleary knolleary deleted the common-look-register-buttons branch March 14, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Add/Register Device buttons and dialogs
2 participants