Better framing of "Application" & "Device" views #1853
Conversation
|
No direct issue for this, so assigning labels so that it shows on the Dev Board |
joepavitt
added
task
| @@ -44,7 +75,9 @@ import { Roles } from '@core/lib/roles' | |||
|
|
|||
| // components | |||
| import NavItem from '@/components/NavItem' | |||
| import SectionTopMenu from '@/components/SectionTopMenu' | |||
| import InstanceStatusHeader from '@/components/InstanceStatusHeader' | |||
There was a problem hiding this comment.
Perhaps better for a wider discussion, but I'd strongly prefer we start using relative paths.
The magic @ alias:
- Locks us to webpack making it harder to swap to another tool
- Prevents lots of tooling from working correctly, including VSCodes "open file" shortcuts.
- Prevents static analysis (one of the key advantages to ES6 imports)
- Doesn't autocomplete
- Makes it harder to differentiate the scope of the component
There was a problem hiding this comment.
Perhaps better for a wider discussion,
Worth opening thread in Slack or issue to capture the sweep required to remove. I prefer the cleanliness of the path to read, and find it a lot easier to find the files when I have an "absolute" path, but appreciate your points presented, and would be fine to change.
There was a problem hiding this comment.
Although isn't the "@" alias part of vitest rather than webpack?
There was a problem hiding this comment.
It looks like vitest had to be told about the webpack alias to be able to resolve files properly.
The aliases are set up in config/webpack.config.js
Description
Inspired by #1852 I've decided to use that same header style across our Applications & Devices too, it offers better boundaries, and also targets some of the thinking in #1830 whereby it's now possible to go from a Device straight to it's attached Instance.
Application View:
Device View:
Checklist