Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "Instances" top-level option #1852

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Add new "Instances" top-level option #1852

merged 5 commits into from
Mar 21, 2023

Conversation

joepavitt
Copy link
Contributor

@joepavitt joepavitt commented Mar 16, 2023

Description

Screen.Recording.2023-03-16.at.15.42.06.mov
  • Adds "Instances" view to list all instances. For now, this just returns the /projects endpoint, but can be updated once the server-side changes are done.
  • Remodels the side bar when looking at an Instance, since you can now navigate here via the Application, or the top-level list. As such, I've added a new "Application: " in the new Instance Status Header

Aware of duplicated icons, these will be tackled in a future PR when I re-work the "Applications"/'Overview" page in #1851

Related Issue(s)

Closes #1849

Checklist

@joepavitt joepavitt changed the title Add new "Instance" top-level option Add new "Instances" top-level option Mar 16, 2023
@joepavitt joepavitt requested a review from Pezmc March 20, 2023 07:13
@Pezmc
Copy link
Contributor

Pezmc commented Mar 20, 2023

@joepavitt Have pushed 2821cc9 which addressed all my nitpick comments rather than leaving all of them on this PR.

Copy link
Contributor

@Pezmc Pezmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily blocking this PR while we discuss #1851

Copy link
Contributor

@Pezmc Pezmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking on the understanding this is a quick fix and there's further iteration to follow as part of #1689

@joepavitt joepavitt merged commit 84677da into main Mar 21, 2023
@joepavitt joepavitt deleted the 1849-instances-view branch March 21, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top-Level "Instances" View
2 participants