Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use application list to determine if team is empty (backport #2035) #2036

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

github-actions[bot]
Copy link

Backport of #2035


Fixes #2031

Description

Uses the application list api to determine if the team is empty or not.

Adds test coverage for the team delete ui.

Note: I've had to add the new _spec file to the list of those for which the require-data-selectors lint rule is disabled. This is because the fix is needed upstream in ui-components to add data attributes to the ff-dialog components.

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
  • Upgrade instructions
  • Configuration details
  • Concepts
  • Changes flowforge.yml?
  • Issue/PR raised on flowforge/helm to update ConfigMap Template
  • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary knolleary self-requested a review April 24, 2023 14:33
@knolleary knolleary merged commit b2e446e into maintenance Apr 24, 2023
@knolleary knolleary deleted the backport-2035 branch April 24, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant