Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use application list to determine if team is empty #2035

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Apr 24, 2023

Fixes #2031

Description

Uses the application list api to determine if the team is empty or not.

Adds test coverage for the team delete ui.

Note: I've had to add the new _spec file to the list of those for which the require-data-selectors lint rule is disabled. This is because the fix is needed upstream in ui-components to add data attributes to the ff-dialog components.

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - and I see you delved into the cypress stuff

not fun is it 😉

There are chrome plugins but they tend to be not great.

@Steve-Mcl Steve-Mcl merged commit be24321 into main Apr 24, 2023
@Steve-Mcl Steve-Mcl deleted the 2031-fix-team-application-count branch April 24, 2023 13:39
knolleary added a commit that referenced this pull request Apr 24, 2023
Use application list to determine if team is empty (backport #2035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete a team
2 participants