Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint: Explicitly enable no-only and set root flag #2132

Merged
merged 2 commits into from
May 12, 2023
Merged

ESLint: Explicitly enable no-only and set root flag #2132

merged 2 commits into from
May 12, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented May 12, 2023 •
edited
Loading

Description

  • Set root flag to ensure eslint doesn't inherit other rules
  • Explicitly enable the no-only tests rule (previously only enabled in flowforge-dev-env

Relevant Slack Thread

Related Issue(s)

#1990

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass - Not relevant
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from Steve-Mcl May 12, 2023 08:53
@Pezmc Pezmc merged commit 0c021ed into main May 12, 2023
2 checks passed
@Pezmc Pezmc deleted the 1990-eslint-follow-ups branch May 12, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

@Steve-Mcl Steve-Mcl Awaiting requested review from Steve-Mcl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pezmc @knolleary