ESLint: Quick clean up #1990
ESLint: Quick clean up #1990
Conversation
|
@Pezmc , ping me when you are back at work please. would like to pick a suitable time to review and merge. I am certain any time if fine want to check with you first. |
|
@Steve-Mcl It's a shame this couldn't go in while I was out, I had hoped to get it merged before everyone created more branches to help avoid merge conflicts, but yes, will ping you when I see you're online. |
|
@Steve-Mcl too late for 1.7 now, but what was blocking getting this merged? |
|
Nothing much @knolleary. Seem to remember I had a questions on the rules - but more than anything, I wanted to check and coordinate the work with Pez to announce in the slack channel a suitable merge time so as not to disrupt too much WIP. Just turned out the timing of vacations caused weeks of delayed responses and it fell off the radar. As it happens, this would be an ideal candidate to get in straight after 1.7 release. |
|
I propose as soon as 1.7 is released, I rebase this onto main and fix up any new eslint failures, then we merge asap before too many new branches are opened ready for 1.8. |
|
@Pezmc agreed. To ensure this doesnt slip through the net again, lets make sure we alert each other when we are ready to rock n roll this. |
Pezmc
force-pushed
the
chore-eslint-cleanup
branch
from
b132207
to
ebd88f1
Compare
|
Rebased onto main, this PR is good to go out, assume tests pass, as soon as it's approved @knolleary @Steve-Mcl, ideally that's by end of day today. |
|
Good stuff. Gonna do it within the next hour Pez |
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
Description
Some quick cleanup of low hanging ESLint fruit between releases before new branches are opened (should be merged after release).