Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint for setting ha configuration on an instance #2207

Merged
merged 1 commit into from
May 31, 2023

Conversation

knolleary
Copy link
Member

Description

This adds an EE only end point for updating an instance's HA configuration:

  • GET /api/v1/projects/:projectId/ha - returns the current HA config
  • PUT /api/v1/projects/:projectId/ha - updates the current HA config
  • DELETE /api/v1/projects/:projectId/ha - deletes the current HA config

The response from GET is:

  • if HA is enabled on the instance: { replicas: 2 }
  • if HA is not enabled: { }

The update end point (PUT...) expects an object of the form: { replicas: 2}. It will only accept a value of 2 for the replica count in this iteration.

@knolleary knolleary requested a review from hardillb May 31, 2023 16:43
@hardillb
Copy link
Contributor

Test failures are the same blank lines as with the patch release.

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but needs opening blank lines removing from files to pass tests

@knolleary
Copy link
Member Author

I'll rebase both branches

@knolleary knolleary force-pushed the 2156-ha-replicas-initial-ui branch from 388ff79 to d8d9dc7 Compare May 31, 2023 18:20
@knolleary knolleary merged commit f365c42 into 2156-ha-replicas May 31, 2023
@knolleary knolleary deleted the 2156-ha-replicas-initial-ui branch May 31, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants