Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines: Catch Creation Failure #2211

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Pipelines: Catch Creation Failure #2211

merged 1 commit into from
Jun 2, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Jun 2, 2023

Description

Checked all pipelines endpoints with faux errors, this was the only one where the UI appeared to hang. Moved reset of loading outside of the try/catch loop.

Related Issue(s)

Fixes #2162

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass - No E2E tests in this area
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • [-] Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from joepavitt June 2, 2023 08:59
@joepavitt joepavitt merged commit cd2fa36 into main Jun 2, 2023
@joepavitt joepavitt deleted the fix-2162-stuck-loading branch June 2, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipelines: UI bug (stuck loading) when server side validation fails when creating stage
2 participants