Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: Some cleanup #2237

Merged
merged 11 commits into from
Jun 6, 2023
Merged

ESLint: Some cleanup #2237

merged 11 commits into from
Jun 6, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Jun 6, 2023

Description

Addresses some low hanging disables in our eslint rules files
I've fixed rules that don't require changing code functionality, could be auto-fixed, or there were only a few instances of.

  • Remove the import/order mute
  • Remove the promise/always-return rule mute
  • Auto-sort all imports
  • Remove old rule disables
  • Fix vue/require-default-prop
  • Fix vue/this-in-template
  • Fix vue/no-multi-spaces
  • Mute vue/no-v-html where it needs to be used

Related Issue(s)

N/a

Checklist

  • I have read the contribution guidelines
  • [-] Suitable unit/system level tests have been added and they pass - No new changes
  • [-] Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from Steve-Mcl June 6, 2023 11:04
@@ -43,7 +44,7 @@ module.exports = fp(async function (app, _opts, next) {

app.ready().then(async () => {
// Once the whole platform is ready, tell the client to connect
await client.init()
return await client.init()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a confusing mix of promises and async behaviour. I chose not to refactor it for risk of including a regression.

@Pezmc Pezmc marked this pull request as ready for review June 6, 2023 12:56
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Visually checked all 182 files for any scripted anomalies. OK
  • Checked cases where an explicit return value was added. OK

TODO:

  • Pull and fire up locally on win box
  • Approve
  • Announce on Dev
  • Merge

@Steve-Mcl Steve-Mcl self-requested a review June 6, 2023 15:53
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Announced on dev channel. Good to go once GH tests complete

@Steve-Mcl Steve-Mcl merged commit 7563f56 into main Jun 6, 2023
@Steve-Mcl Steve-Mcl deleted the eslint-remove-skipped-files branch June 6, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants