Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependencies: Remove base64url #2242

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Remove dependencies: Remove base64url #2242

merged 1 commit into from
Jun 7, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Jun 6, 2023 •
edited
Loading

Description

Merged target is remove-dependencies, this PR should be rebased onto master.

We already have a base64url method in the codebase, so this module is redundant.

Related Issue(s)

None

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass - No new features
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Pezmc Pezmc requested a review from knolleary June 6, 2023 13:12
Base automatically changed from remove-dependencies to main June 7, 2023 08:30
@Pezmc
Copy link
Contributor Author

Pezmc commented Jun 7, 2023

Rebased onto main

knolleary
knolleary approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a few moments to spot the different in the utils sha256 and the one being removed, and why you then used URLEncode and node base64UrlEncode... but got there eventually.

Have tested with my local SSO setup against OneLogin. Plus the tools plugin unit test looks good.

@knolleary knolleary merged commit c936172 into main Jun 7, 2023
@knolleary knolleary deleted the remove-dependencies-2 branch June 7, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pezmc @knolleary