Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker to use volume flag #2498

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Update docker to use volume flag #2498

merged 2 commits into from
Jul 18, 2023

Conversation

ZJvandeWeg
Copy link
Member

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@ZJvandeWeg ZJvandeWeg requested a review from hardillb July 18, 2023 11:48
hardillb
hardillb reviewed Jul 18, 2023
View reviewed changes
docs/device-agent/install.md Outdated

Or you can chose to run the Docker container. When you do, you'll need to mount
the `device.yml` obtained when [Registering the device](./register.md):

```bash
docker run --mount /path/to/device.yml:/opt/flowforge-device/device.yml -p 1880:1880 flowforge/device-agent:latest
docker run --volume /path/to/device.yml:/opt/flowforge-device/device.yml -p 1880:1880 flowforge/device-agent:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.docker.com/engine/reference/commandline/run/#mount

Suggests that --mount is the preferred way to do this.

@ZJvandeWeg ZJvandeWeg requested a review from hardillb July 18, 2023 13:33
@hardillb hardillb merged commit 03304fd into main Jul 18, 2023
1 check passed
@hardillb hardillb deleted the ZJvandeWeg-patch-2 branch July 18, 2023 13:35
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
Merged
11 tasks
ZJvandeWeg added a commit that referenced this pull request Jul 19, 2023
@ZJvandeWeg
Merge pull request #2499 from flowforge/backport-2498
498ecae 
Update docker to use volume flag (backport #2498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZJvandeWeg @hardillb