Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type param to required while creating a team #3597

Merged

Conversation

Jayanth-Parthsarathy
Copy link
Contributor

Description

  • Changes type param in the swagger docs to be required while creating a team.
  • This was not required earlier and would return a HTTP 500 error when trying to create a team without the type parameter.

Related Issue(s)

Fixes #3596

Checklist

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.89%. Comparing base (5eea098) to head (7039d2e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3597   +/-   ##
=======================================
  Coverage   41.89%   41.89%           
=======================================
  Files         625      625           
  Lines       24252    24252           
  Branches     5916     5916           
=======================================
  Hits        10161    10161           
  Misses      14091    14091           
Flag Coverage Δ
backend 78.51% <ø> (ø)
frontend 1.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb
Copy link
Contributor

@Jayanth-Parthsarathy Thanks

@hardillb hardillb merged commit 835176f into FlowFuse:main Mar 19, 2024
7 checks passed
@Jayanth-Parthsarathy Jayanth-Parthsarathy deleted the 3596-create-team-type-param branch March 19, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type parameter is not marked as required for /api/v1/teams/ endpoint
2 participants