Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate kb and km for apiMaxLength #3603

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Validate kb and km for apiMaxLength #3603

merged 1 commit into from
Mar 20, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Mar 20, 2024

Description

Ensures user input is nkb or nmb for apiMaxLength

Related Issue(s)

#3577

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from hardillb March 20, 2024 08:30
@Steve-Mcl Steve-Mcl linked an issue Mar 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.89%. Comparing base (35ddb79) to head (3042e07).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3603   +/-   ##
=======================================
  Coverage   41.89%   41.89%           
=======================================
  Files         625      625           
  Lines       24288    24288           
  Branches     5929     5929           
=======================================
  Hits        10176    10176           
  Misses      14112    14112           
Flag Coverage Δ
backend 78.53% <100.00%> (ø)
frontend 1.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hardillb hardillb merged commit c045c60 into main Mar 20, 2024
7 checks passed
@hardillb hardillb deleted the 3577-byte-size-string branch March 20, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow HTTP max payload size to be configured
2 participants