-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX Improvements to Immersive Editor #3753
UX Improvements to Immersive Editor #3753
Conversation
I'm not fully satisfied with the resizing action as there's a slight delay when dragging the drawer (unlike some vue plugins I checked out) but it'll do for now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3753 +/- ##
=======================================
Coverage 79.14% 79.14%
=======================================
Files 278 278
Lines 12487 12487
Branches 2761 2761
=======================================
Hits 9883 9883
Misses 2604 2604
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assuming this is because of the CSS transition on the draw height? Just fixed it with abd83ac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @cstns - made a couple of very minor improvements, but otherwise, works great. Just updated to latest of main
, will wait for tests to run, but should all be fine.
Description
Related Issue(s)
ref #3646
closes #3657
Checklist
I have read the contribution guidelinesDocumentation has been updatedUpgrade instructionsConfiguration detailsConceptsChangesflowforge.yml
?Issue/PR raised onFlowFuse/helm
to update ConfigMap TemplateIssue/PR raised onFlowFuse/CloudProject
to update values for Staging/ProductionLabels
Backport needed? -> add thebackport
labelIncludes a DB migration? -> add thearea:migration
label