Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to Suspend Project #893

Merged
merged 11 commits into from Aug 19, 2022
Merged

Add option to Suspend Project #893

merged 11 commits into from Aug 19, 2022

Conversation

hardillb
Copy link
Contributor

This adds an option under the Project Settings Danger page. It asks for the same confirmation as delete

fixes #377

@hardillb
Add option to Suspend Project
8f0fd80 
This adds an option under the Project Settings Danger page. It asks
for the same confirmation as delete
@hardillb hardillb added this to the 0.9 milestone Aug 15, 2022
@hardillb hardillb self-assigned this Aug 15, 2022
@hardillb
Swap stop for suspend in menu
47e67bb 
Also remove need to enter project name to confirm suspension
@hardillb
Update copy for suspend option
e009d37
@hardillb
Copy link
Contributor Author

hardillb commented Aug 16, 2022 •
edited

fixes #836

@hardillb hardillb marked this pull request as ready for review August 16, 2022 11:07
@joepavitt
Copy link
Contributor

@hardillb Might be worth holding on this until #900 is merged, then we can utilise the new Dialog JS API, which streamlines the confirmation process here.

@hardillb @joepavitt
Update frontend/src/pages/project/Settings/Danger.vue
f9e07d5 
Co-authored-by: Joe Pavitt <99246719+joepavitt@users.noreply.github.com>
@hardillb
Copy link
Contributor Author

Sounds like a plan

@joepavitt
Copy link
Contributor

I've also just added some conditional disabling/messaging when a project is suspended.

Screenshot 2022-08-19 at 10 50 43

hardillb
hardillb commented Aug 19, 2022
View reviewed changes
Copy link
Contributor Author

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd approve Joe's update, but github won't let me

@joepavitt joepavitt merged commit 15b369e into main Aug 19, 2022
@joepavitt joepavitt deleted the suspend-project branch August 19, 2022 10:51
@sammachin sammachin linked an issue Aug 22, 2022 that may be closed by this pull request
Remove Stop from Project Actions #836
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

Remove Stop from Project Actions Allow user to suspend project so it doesnt consume resources
2 participants
@hardillb @joepavitt