New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog JS API #900
Merged
Merged
Dialog JS API #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steve-Mcl
reviewed
Aug 18, 2022
Steve-Mcl
reviewed
Aug 18, 2022
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
…nto dialog-api
Steve-Mcl
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All viewed, ran locally, all good :)
All issues resolved, ready to merge @joepavitt 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #830
JS API
Includes additional JS api to open Dialogs. I've overridden the initial dialogs where appropriate, mostly in "Delete" use cases, e.g.:
Architecture
The core dialog service lives in
./frontend/src/services/dialog.js
. The key.show()
function is used across the app in order to show and act upon confirmation of any dialogs.The
bind
function is called from./frontend/src/layouts/Platform.vue
. There is an instance offf-dialog
here that is driven by thebind
function. Whenshow()
is called, the dialog being modified/shown is this instance.Testing
Given that we now have E2E testing up and running, I've also used this as an opportunity to include a bunch of E2E tests that then cover a lot of primary use cases that use these Dialogs. I haven't gone for 100% coverage on this, but it's a significant dent into a backlog of technical testing debt too.