Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use sensitive values from 1Password vault in helm deployment workflow #37

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

ppawlowski
Copy link
Collaborator

@ppawlowski ppawlowski commented Mar 10, 2024

Description

This PR extends existing helm chart deployment reusable workflow by adding a possibility to use sensitive values stored in 1Password vault.
Workflow is extended by:

  • 1Password CLI installation step
  • render template file step (using op inject approach)
  • prepare VALUE_FILES environmental variable - coma-separated list of value files used by the helm chart deployment action

Additionally, it sorts input values in a alphabetical order.

Related Issue(s)

https://github.com/FlowFuse/CloudProject/issues/366

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb merged commit f4349ab into main Mar 11, 2024
@hardillb hardillb deleted the feat-helm-1p branch March 11, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants