Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add possibility to configure securityContext for each pod #275

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Jan 11, 2024

Description

Add possibility to configure securityContext for forge and broker pods.
Additionally, set a default value for seccompProfile to RuntimeDefault for both pods.

Related Issue(s)

#323
#268

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

Copy link

node-red:3.1.x-main-linux-amd64 scan results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 00f46d8. ± Comparison against base commit 60776ce.

Copy link

node-red:3.0.2-main-linux-amd64 scan results

1 files  ±0  4 suites  ±0   0s ⏱️ ±0s
8 tests ±0  0 ✅ ±0  0 💤 ±0  8 ❌ ±0 
9 runs  ±0  0 ✅ ±0  0 💤 ±0  9 ❌ ±0 

For more details on these failures, see this check.

Results for commit 00f46d8. ± Comparison against base commit 60776ce.

Copy link

node-red:2.2.3-main-linux-amd64 scan results

26 tests  ±0    0 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0   26 ❌ ±0 

For more details on these failures, see this check.

Results for commit 00f46d8. ± Comparison against base commit 60776ce.

Copy link

node-red:2.2.3-main-linux-arm64 scan results

26 tests  ±0    0 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0   26 ❌ ±0 

For more details on these failures, see this check.

Results for commit 00f46d8. ± Comparison against base commit 60776ce.

Copy link

node-red:3.0.2-main-linux-arm64 scan results

1 files  ±0  4 suites  ±0   0s ⏱️ ±0s
8 tests ±0  0 ✅ ±0  0 💤 ±0  8 ❌ ±0 
9 runs  ±0  0 ✅ ±0  0 💤 ±0  9 ❌ ±0 

For more details on these failures, see this check.

Results for commit 00f46d8. ± Comparison against base commit 60776ce.

Copy link

node-red:3.1.x-main-linux-arm64 scan results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 00f46d8. ± Comparison against base commit 60776ce.

@hardillb
Copy link
Contributor

@ppawlowski do we need to talk about what security context will be applied to the NR instance pods?

@ppawlowski ppawlowski changed the base branch from main to v2 January 12, 2024 09:36
@hardillb hardillb mentioned this pull request Jan 12, 2024
12 tasks
@ppawlowski
Copy link
Contributor Author

@ppawlowski do we need to talk about what security context will be applied to the NR instance pods?

NR instances are created by the application with kubernetes driver thus it is outside of the scope of the change introduced in this PR. However, it is worth to implement security context parameters on NR as well, but as a separate task.

@hardillb
Copy link
Contributor

NR instances are created by the application with kubernetes driver thus it is outside of the scope of the change introduced in this PR. However, it is worth to implement security context parameters on NR as well, but as a separate task.

Yes, but I was meaning should we have a paired drive pr to match? And should it use some of the same values?

@ppawlowski
Copy link
Contributor Author

NR instances are created by the application with kubernetes driver thus it is outside of the scope of the change introduced in this PR. However, it is worth to implement security context parameters on NR as well, but as a separate task.

Yes, but I was meaning should we have a paired drive pr to match? And should it use some of the same values?

Can be implemented independently. Regarding values - for the seccomp profile it should be fine, although some tests should be performed. For the user/group ID - this might change due to #251 .

@hardillb
Copy link
Contributor

OK, so the only thing missing from this (we will look at the driver update later) is adding to the file-server pod

@hardillb hardillb merged commit b6dbf87 into v2 Jan 12, 2024
2 checks passed
@hardillb hardillb deleted the feat-podsecuritycontext branch January 12, 2024 14:53
@ppawlowski ppawlowski mentioned this pull request Jan 17, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants