Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Helm chart v2 #279

Merged
merged 53 commits into from
Jan 17, 2024
Merged

feat: Helm chart v2 #279

merged 53 commits into from
Jan 17, 2024

Conversation

ppawlowski
Copy link
Contributor

@ppawlowski ppawlowski commented Jan 17, 2024

Description

This PR presents all changes we would like to introduce in Flowfuse Helm v2:

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

Copy link

github-actions bot commented Jan 17, 2024

node-red:2.2.3-main-linux-amd64 scan results

26 tests  ±0    0 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0   26 ❌ ±0 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 17, 2024

node-red:3.0.2-main-linux-amd64 scan results

1 files  ±0  4 suites  ±0   0s ⏱️ ±0s
7 tests  - 4  0 ✅ ±0  0 💤 ±0  7 ❌  - 4 
8 runs   - 4  0 ✅ ±0  0 💤 ±0  8 ❌  - 4 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

This pull request removes 7 and adds 3 tests. Note that renamed tests count towards both.
follow-redirects-1.15.3 ‑ [MEDIUM] CVE-2023-26159
libcrypto3-3.1.4-r1 ‑ [MEDIUM] CVE-2023-6129
libssl3-3.1.4-r1 ‑ [MEDIUM] CVE-2023-6129
openssh-client-common-9.3_p2-r0 ‑ [MEDIUM] CVE-2023-48795
openssh-client-default-9.3_p2-r0 ‑ [MEDIUM] CVE-2023-48795
openssh-keygen-9.3_p2-r0 ‑ [MEDIUM] CVE-2023-48795
openssl-3.1.4-r1 ‑ [MEDIUM] CVE-2023-6129
libcrypto3-3.1.4-r3 ‑ [MEDIUM] CVE-2023-6237
libssl3-3.1.4-r3 ‑ [MEDIUM] CVE-2023-6237
openssl-3.1.4-r3 ‑ [MEDIUM] CVE-2023-6237

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 17, 2024

file-server:main-linux-amd64 scan results

4 tests  +2   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   4 ❌ +2 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 17, 2024

node-red:3.1.x-main-linux-amd64 scan results

3 tests  +3   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   3 ❌ +3 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 17, 2024

node-red:3.1.x-main-linux-arm64 scan results

3 tests  +3   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   3 ❌ +3 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 17, 2024

forge-k8s:main-linux-amd64 scan results

5 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   5 ❌ ±0 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 17, 2024

node-red:2.2.3-main-linux-arm64 scan results

26 tests  ±0    0 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0   26 ❌ ±0 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 17, 2024

node-red:3.0.2-main-linux-arm64 scan results

1 files  ±0  4 suites  ±0   0s ⏱️ ±0s
7 tests  - 4  0 ✅ ±0  0 💤 ±0  7 ❌  - 4 
8 runs   - 4  0 ✅ ±0  0 💤 ±0  8 ❌  - 4 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

This pull request removes 7 and adds 3 tests. Note that renamed tests count towards both.
follow-redirects-1.15.3 ‑ [MEDIUM] CVE-2023-26159
libcrypto3-3.1.4-r1 ‑ [MEDIUM] CVE-2023-6129
libssl3-3.1.4-r1 ‑ [MEDIUM] CVE-2023-6129
openssh-client-common-9.3_p2-r0 ‑ [MEDIUM] CVE-2023-48795
openssh-client-default-9.3_p2-r0 ‑ [MEDIUM] CVE-2023-48795
openssh-keygen-9.3_p2-r0 ‑ [MEDIUM] CVE-2023-48795
openssl-3.1.4-r1 ‑ [MEDIUM] CVE-2023-6129
libcrypto3-3.1.4-r3 ‑ [MEDIUM] CVE-2023-6237
libssl3-3.1.4-r3 ‑ [MEDIUM] CVE-2023-6237
openssl-3.1.4-r3 ‑ [MEDIUM] CVE-2023-6237

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 17, 2024

file-server:main-linux-arm64 scan results

4 tests  +2   0 ✅ ±0   0s ⏱️ ±0s
2 suites ±0   0 💤 ±0 
1 files   ±0   4 ❌ +2 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

♻️ This comment has been updated with latest results.

@hardillb hardillb changed the title Helm chart v2 feat: Helm chart v2 Jan 17, 2024
Copy link

github-actions bot commented Jan 17, 2024

forge-k8s:main-linux-arm64 scan results

5 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
4 suites ±0   0 💤 ±0 
1 files   ±0   5 ❌ ±0 

For more details on these failures, see this check.

Results for commit d1dd9b7. ± Comparison against base commit 33e4c2a.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It mainly looks good, with just the comment about the forge.domain entry in the default values file.

Need to decide if we update the tests to pass --set-string forge.domain=example.com or keep the change.

helm/flowforge/values.yaml Outdated Show resolved Hide resolved
@hardillb
Copy link
Contributor

Looks good, will let the tests finish and then approve

@hardillb hardillb merged commit 345433a into main Jan 17, 2024
41 checks passed
@hardillb hardillb deleted the v2 branch January 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants