Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radio group selection fix #822

Merged
merged 1 commit into from
May 7, 2024
Merged

radio group selection fix #822

merged 1 commit into from
May 7, 2024

Conversation

bartbutenaers
Copy link
Contributor

Description

When adding dynamic radiobutton options (see pr), a bug was introduced.

Related Issue(s)

issue 818

Checklist

  • [ X ] I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@bartbutenaers bartbutenaers mentioned this pull request May 1, 2024
Closed
@joepavitt
Copy link
Collaborator

Thanks for the fix - not sure how the E2E test we had in place to check this didn't flag this previously. The test case checks exactly this problem...

@joepavitt joepavitt merged commit c7aa38c into FlowFuse:main May 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepavitt joepavitt joepavitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartbutenaers @joepavitt