-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node-RED: Allow flows to be rendered as diagrams #1985
Conversation
Utilizes the upstream package remove the need for images + plain JSON. For this change I've only shown the split node as an example page. The rest of the nodes will be added later, though there's some upstream changes that would be better to add before we roll these changes out wholesale.
@Yndira-E You can find the result at: https://deploy-preview-1985--flowforge-website.netlify.app/node-red/core-nodes/split/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![Node-RED split by word](./images/split-node-by-word.png "Split text by space in Node-RED") | ||
|
||
```json | ||
{% renderFlow 400 %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yndira-E here's an example where height is set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's caused by FlowFuse/flow-renderer#28
I'd say it's worth a quick fix of FlowFuse/flow-renderer#28 before putting this live onto the website |
Now 0.3 is released the minification is provided upstream. Furthermore, the height can be decreased as the viewport automatically puts the top-left node right in the view.
@Yndira-E @joepavitt the last commit, b31a9ca, bumps the upstream package and decreased the elements' height by default to 200px as it automatically puts the top-left node close to the screenspace top-left (sorry for the awkward description). I believe this PR is now ready to be merged. The cascading changes for other pages I'll pick up later today to ensure that PR is highly focussed and can serve as an example for the writers. |
Validated the deploy preview, and going ahead with merging. |
Utilizes the upstream package remove the need for
images + plain JSON.
For this change I've only shown the split node as an example page. The rest of the nodes will be added
later, though there's some upstream changes that
would be better to add before we roll these changes out wholesale.
Related Issue(s)
Would be ideal to have: FlowFuse/flow-renderer#28 soonish to fix the height requiring manual checks and updates.
Checklist