Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore null IMEI/IMSI in QA checks #6621

Merged
merged 4 commits into from
May 23, 2024
Merged

Ignore null IMEI/IMSI in QA checks #6621

merged 4 commits into from
May 23, 2024

Conversation

jc-harrison
Copy link
Member

@jc-harrison jc-harrison commented May 22, 2024

Closes #6619

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Updates FlowETL IMEI/IMSI QA checks to ignore null values

@jc-harrison jc-harrison added bug Something isn't working FlowETL labels May 22, 2024
Copy link

cypress bot commented May 22, 2024

Passing run #22659 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge branch 'master' into fix-qa-checks
Project: FlowAuth Commit: 61d299d19a
Status: Passed Duration: 00:50 💡
Started: May 23, 2024 9:55 AM Ended: May 23, 2024 9:55 AM

Review all test suite changes for PR #6621 ↗︎

@jc-harrison jc-harrison added the ready-to-merge Label indicating a PR is OK to automerge label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.31%. Comparing base (4d9fcea) to head (800c978).

Current head 800c978 differs from pull request most recent head 61d299d

Please upload reports for the commit 61d299d to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6621       +/-   ##
===========================================
+ Coverage   77.11%   92.31%   +15.19%     
===========================================
  Files         268      268               
  Lines       10586    10586               
  Branches      855      855               
===========================================
+ Hits         8163     9772     +1609     
+ Misses       2169      676     -1493     
+ Partials      254      138      -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot merged commit be80d35 into master May 23, 2024
39 checks passed
@mergify mergify bot deleted the fix-qa-checks branch May 23, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowETL ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMSI/IMEI QA checks should ignore nulls
2 participants