Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding api routes to servers #1817

Merged
merged 4 commits into from
Jan 20, 2020
Merged

Fix adding api routes to servers #1817

merged 4 commits into from
Jan 20, 2020

Conversation

greenape
Copy link
Member

Closes #1815

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Fixes all the checkboxes being disabled when trying to assign routes to servers. Related issue (#1816) is that we have slightly different behaviour when the backend is in demo mode, and the tests are using that.

I've changed the route (which is only used here) to return with everything switched on, and cleaned up the componentdidmount function a little frontend side.

@greenape greenape added bug Something isn't working FlowAuth Issues related to FlowAuth ready-to-merge Label indicating a PR is OK to automerge labels Jan 20, 2020
@cypress
Copy link

cypress bot commented Jan 20, 2020



Test summary

57 0 0 0


Run details

Project FlowAuth
Status Passed
Commit 7927f7e
Started Jan 20, 2020 1:00 PM
Ended Jan 20, 2020 1:02 PM
Duration 02:21 💡
OS Linux Debian - 8.11
Browser Electron 78

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jc-harrison jc-harrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #1817 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
+ Coverage   95.17%   95.23%   +0.06%     
==========================================
  Files         186      188       +2     
  Lines        8220     8331     +111     
  Branches      783      789       +6     
==========================================
+ Hits         7823     7934     +111     
  Misses        283      283              
  Partials      114      114
Flag Coverage Δ
#autoflow_unit_tests 92.91% <ø> (ø) ⬆️
#flowapi_unit_tests 83.97% <ø> (ø) ⬆️
#flowauth_unit_tests 93.65% <100%> (-0.01%) ⬇️
#flowclient_unit_tests 78.78% <ø> (ø) ⬆️
#flowetl_unit_tests 97.35% <ø> (ø) ⬆️
#flowkit_jwt_generator_unit_tests 100% <ø> (?)
#flowmachine_unit_tests 90.97% <ø> (ø) ⬆️
#integration_tests 69.52% <ø> (ø) ⬆️
Impacted Files Coverage Δ
flowauth/backend/flowauth/admin.py 96.95% <100%> (-0.01%) ⬇️
flowkit_jwt_generator/flowkit_jwt_generator/jwt.py 100% <0%> (ø)
...it_jwt_generator/flowkit_jwt_generator/fixtures.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a04490b...7927f7e. Read the comment docs.

@mergify mergify bot merged commit 6339526 into master Jan 20, 2020
@mergify mergify bot deleted the fix-server-capabiities branch January 20, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowAuth Issues related to FlowAuth ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't enable capabilities or aggregation units on servers
2 participants