Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read access in etl schema #1818

Merged
merged 3 commits into from Jan 21, 2020
Merged

Read access in etl schema #1818

merged 3 commits into from Jan 21, 2020

Conversation

greenape
Copy link
Member

flowmachine user now has read access to the etl schema both so that it can read etl metadata, and so that etl'd tables are properly readable.

@greenape greenape added FlowDB Issues related to FlowDB ready-to-merge Label indicating a PR is OK to automerge labels Jan 20, 2020
@cypress
Copy link

cypress bot commented Jan 20, 2020



Test summary

57 0 0 0


Run details

Project FlowAuth
Status Passed
Commit 09811e0
Started Jan 21, 2020 1:16 PM
Ended Jan 21, 2020 1:19 PM
Duration 02:44 💡
OS Linux Debian - 8.11
Browser Electron 78

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #1818 into master will increase coverage by 0.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1818      +/-   ##
==========================================
+ Coverage   94.32%   95.27%   +0.94%     
==========================================
  Files         188      188              
  Lines        9320     8331     -989     
  Branches      789      789              
==========================================
- Hits         8791     7937     -854     
+ Misses        393      282     -111     
+ Partials      136      112      -24
Flag Coverage Δ
#autoflow_unit_tests 92.91% <ø> (-7.09%) ⬇️
#flowapi_unit_tests 83.97% <ø> (ø) ⬆️
#flowauth_unit_tests 93.65% <ø> (ø) ⬆️
#flowclient_unit_tests 78.78% <ø> (ø) ⬆️
#flowetl_unit_tests 97.35% <ø> (ø) ⬆️
#flowkit_jwt_generator_unit_tests 100% <ø> (ø) ⬆️
#flowmachine_unit_tests 90.97% <ø> (ø) ⬆️
#integration_tests 69.56% <ø> (-0.78%) ⬇️
Impacted Files Coverage Δ
flowauth/backend/flowauth/login.py 95.12% <0%> (ø) ⬆️
autoflow/autoflow/__main__.py 0% <0%> (-96.66%) ⬇️
flowetl/etl/etl/postetl_queries.py 100% <0%> (ø) ⬆️
flowauth/backend/flowauth/version.py 100% <0%> (ø) ⬆️
flowmachine/flowmachine/features/location/pwo.py 85.18% <0%> (ø) ⬆️
...w/autoflow/parser/available_dates_sensor_schema.py 100% <0%> (ø) ⬆️
flowauth/backend/flowauth/admin.py 96.95% <0%> (ø) ⬆️
flowauth/backend/flowauth/models.py 93.37% <0%> (ø) ⬆️
flowauth/backend/flowauth/user_settings.py 92.1% <0%> (ø) ⬆️
autoflow/autoflow/app.py 100% <0%> (+2.56%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db55c48...09811e0. Read the comment docs.

Copy link
Member

@jc-harrison jc-harrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 03ee519 into master Jan 21, 2020
@mergify mergify bot deleted the etl-permissions branch January 21, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowDB Issues related to FlowDB ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants