Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test qa data rename #6470

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Test qa data rename #6470

merged 4 commits into from
Mar 20, 2024

Conversation

Thingus
Copy link
Contributor

@Thingus Thingus commented Mar 19, 2024

Closes #6472

I have:

  • Formatted any Python files with black
  • Brought the branch up to date with master
  • Added any relevant Github labels
  • Added tests for any new additions
  • Added or updated any relevant documentation
  • Added an Architectural Decision Record (ADR), if appropriate
  • Added an MPLv2 License Header if appropriate
  • Updated the Changelog

Description

Renames test QA data to be of the {qa_check_name}.{cdr_type} format.

@mergify mergify bot mentioned this pull request Mar 19, 2024
8 tasks
Copy link

cypress bot commented Mar 20, 2024

Passing run #21896 ↗︎

0 4 0 0 Flakiness 0

Details:

Slightly more explicit changelog entry
Project: FlowAuth Commit: 7d4f485c3d
Status: Passed Duration: 00:43 💡
Started: Mar 20, 2024 3:28 PM Ended: Mar 20, 2024 3:29 PM

Review all test suite changes for PR #6470 ↗︎

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.94%. Comparing base (7567042) to head (7d4f485).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6470   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files         264      264           
  Lines       10307    10307           
  Branches      835      835           
=======================================
  Hits         9580     9580           
  Misses        599      599           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thingus Thingus added FlowDB Issues related to FlowDB FlowAPI Issues related to the FlowKit API FlowETL labels Mar 20, 2024
@Thingus Thingus marked this pull request as ready for review March 20, 2024 13:29
@Thingus Thingus added the Needs Review PR that is ready for review by a human label Mar 20, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@greenape greenape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bueno.

@greenape greenape added the ready-to-merge Label indicating a PR is OK to automerge label Mar 20, 2024
@mergify mergify bot merged commit 59f34c0 into master Mar 20, 2024
42 checks passed
@mergify mergify bot deleted the test_qa_data_rename branch March 20, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FlowAPI Issues related to the FlowKit API FlowDB Issues related to FlowDB FlowETL Needs Review PR that is ready for review by a human ready-to-merge Label indicating a PR is OK to automerge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test-data derived QA check IDs don't match format of actual QA checks
2 participants